Add rubocop to CI and test it against multiple ruby versions#70
Merged
deitch merged 4 commits intodeitch:masterfrom Dec 5, 2022
Merged
Add rubocop to CI and test it against multiple ruby versions#70deitch merged 4 commits intodeitch:masterfrom
deitch merged 4 commits intodeitch:masterfrom
Conversation
deitch
approved these changes
Dec 5, 2022
Owner
deitch
left a comment
deitch
left a comment
There was a problem hiding this comment.
Looks great, and I am happy to have it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to contribute to this gem. So before I do other contributions, I would like to improve the CI adding:
I added the rubocop proposed changes to a different commit, so if you have strong opinions about any proposed change, we can just drop it.
The follow-up PR would be add actually run the tests in a docker compose environment.